Skip to content

feat: handle edited composite messages - WPB-19101 #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Oct 13, 2025
Merged

feat: handle edited composite messages - WPB-19101 #3716

merged 52 commits into from
Oct 13, 2025

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 9, 2025 •
edited by github-actions bot
Loading

StoryWPB-19101 [iOS] Support editing a Composite message

Issue

Until now MessageEdit with a Composite item message types have been ignored, only Text has been handled.
Now with poll on MLS we started using them for dynamically updating the poll's results.

This PR handles messages of type MessageEdit with a Composite item.

Testing

Use the new Poll app in an MLS conversation.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

caldrian and others added 30 commits October 2, 2025 14:48
@caldrian
set UIDesignRequiresCompatibility to YES
ebd5bf5
@caldrian
attempt to fix polls not working
15708f1
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into feat/handl…
f00e811 
…e-composite-messages-WPB-17921
@caldrian
access core data entity properties on the correct queue
8328450
@caldrian
update package
a242250
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into feat/handl…
148fb0d 
…e-composite-messages-WPB-17921
@caldrian
minor adjustments
0cf40d9
@caldrian
prepare for updating composite content
2e9b3d9
@caldrian
revert changes
a3040a0
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into feat/handl…
b9326b7 
…e-composite-messages-WPB-17921
@caldrian
attempt to fix dangling core data objects
8f74bb3
@caldrian
delete redundant line
9ce9909
@caldrian
add workaround
070465b
@caldrian
recreate cell descriptions only for composite messages
44d0c81
@caldrian
add comment
00c3648
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into fix/polls-…
70e2da4 
…proteus-WPB-19765
@caldrian
revert some changes
595c3cf
@caldrian
format code
429a840
@caldrian
Merge branch 'develop' into fix/polls-proteus-WPB-19765
d9e7b98
@caldrian @Copilot
fix ticket number in comment
692392b 
Co-authored-by: Copilot <[email protected]>
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into feat/handl…
463ca66 
…e-composite-messages-WPB-17921
@caldrian
Merge branch 'fix/polls-proteus-WPB-19765' into feat/handle-composite…
65e911d 
…-messages-WPB-17921
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into feat/handl…
814ff1a 
…e-composite-messages-WPB-17921
@caldrian
handle button action event
fe3ebf8
@caldrian
delete redundant type
10846a8
@caldrian
select button on press
307a523
@caldrian
fix bug
438e226
@caldrian
add TODO
fcf7b2b
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into feat/handl…
f978ebf 
…e-composite-messages-WPB-17921
@caldrian
cleanup
d2e54a0
@caldrian caldrian marked this pull request as ready for review October 9, 2025 12:37
@caldrian caldrian changed the title feat: handle edited composite messages - WPB-19101 feat: handle edited composite messages - WPB-19101x Oct 9, 2025
@caldrian caldrian changed the title feat: handle edited composite messages - WPB-19101x feat: handle edited composite messages - WPB-19101 Oct 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

Test Results

    3 files    667 suites   6m 16s ⏱️
4 695 tests 4 668 ✅ 27 💤 0 ❌
4 696 runs  4 669 ✅ 27 💤 0 ❌

Results for commit 3bed4d4.

♻️ This comment has been updated with latest results.

Base automatically changed from feat/handle-composite-messages-WPB-17921 to develop October 10, 2025 18:04
@caldrian caldrian requested review from a team, KaterinaWire and johnxnguyen and removed request for a team October 13, 2025 07:26
@caldrian caldrian added this pull request to the merge queue Oct 13, 2025
Merged via the queue into develop with commit a3d080e Oct 13, 2025
11 checks passed
@caldrian caldrian deleted the feat/support-editing-composite-messages-WPB-19101 branch October 13, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnxnguyen johnxnguyen johnxnguyen approved these changes

@KaterinaWire KaterinaWire KaterinaWire approved these changes

Assignees

@caldrian caldrian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caldrian @johnxnguyen @KaterinaWire